Add all flag to export cluster command #8179
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
Hi @vvbogdanov87. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/M
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/test pull-kops-e2e-kubernetes-aws |
| if err != nil { | ||
| return err | ||
| var clusterList []*api.Cluster | ||
| if options.all { |
There was a problem hiding this comment.
Perhaps fail if len(args) != 0?
|
/test pull-kops-e2e-kubernetes-aws |
|
/test pull-kops-verify-staticcheck |
| var clusterList []*api.Cluster | ||
| if options.all { | ||
| if len(args) != 0 { | ||
| return fmt.Errorf("Cannot use both --args flag and positional arguments") |
There was a problem hiding this comment.
Did you mean "..both --all flag and positional arguments" ?
|
I'm going to use this a lot - thanks @vvbogdanov87 :-) I had one question about whether you wrote "--args" in the error message when you meant "--all", but we can easily fix that up separately if so. /approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, vvbogdanov87 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Closes #140