Refactor: Add Region() method to fi.Cloud #8180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This enables us to simply the apply logic.
justinsb
force-pushed
the
add_region_to_fi_cloud
branch
from
a3a4fc1
to
802b1ad
Compare
|
/test pull-kops-verify-staticcheck |
|
/test pull-kops-e2e-kubernetes-aws |
|
FWIW the vsphere cluster api uses tags to track regions, but since Kops' support does not do that yet I think leaving its value as the cluster name is fine. /lgtm |
k8s-ci-robot
added
the
lgtm
|
/test pull-kops-verify-bazel |
|
/test pull-kops-e2e-kubernetes-aws |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables us to simply the apply logic.