Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix author nickName #8205

Merged
merged 2 commits into from
Jan 16, 2020
Merged

fix author nickName #8205

merged 2 commits into from
Jan 16, 2020

Conversation

LinshanYu
Copy link
Contributor

Edit author nickname

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 27, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @LinshanYu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 27, 2019
@justinsb
Copy link
Member

Hmmm - that's looks like it could be a bug in relnotes: https://github.com/kopeio/shipbot/blob/master/cmd/relnotes/main.go#L199

I don't know if relnotes is picking up the wrong field, or if the user renamed themselves. In any case, it looks like we should change MathieuMailhos to mmailhos throughout - including in the square bracket links (i.e. not just in the URLs) (I think?)

Thanks for fixing this @LinshanYu - how did you find it? (Crawling for broken links?)

@LinshanYu
Copy link
Contributor Author

Hmmm - that's looks like it could be a bug in relnotes: https://github.com/kopeio/shipbot/blob/master/cmd/relnotes/main.go#L199

I don't know if relnotes is picking up the wrong field, or if the user renamed themselves. In any case, it looks like we should change MathieuMailhos to mmailhos throughout - including in the square bracket links (i.e. not just in the URLs) (I think?)

Thanks for fixing this @LinshanYu - how did you find it? (Crawling for broken links?)

Hmmm - that's looks like it could be a bug in relnotes: https://github.com/kopeio/shipbot/blob/master/cmd/relnotes/main.go#L199

I don't know if relnotes is picking up the wrong field, or if the user renamed themselves. In any case, it looks like we should change MathieuMailhos to mmailhos throughout - including in the square bracket links (i.e. not just in the URLs) (I think?)

Thanks for fixing this @LinshanYu - how did you find it? (Crawling for broken links?)

Take a look the link,#6776 ,which the author of is shown in the document which i changed. Just open this link and you will find the real author address

@tanjunchen
Copy link
Member

tanjunchen commented Dec 30, 2019

/ok-to-test
#7944
@LinshanYu
It seems that you refer to this issue.
/cc @justinsb
PTAL
I find there 404 urls by analysising and crawling the repo kops before . So should we change this 404 urls or see our code https://github.com/kopeio/shipbot/blob/master/cmd/relnotes/main.go#L199

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 30, 2019
@justinsb
Copy link
Member

Thanks @LinshanYu - I think the user has renamed themselves, and when I fed this back into relnotes it did output the corrected link. Thanks so much for spotting & fixing.

/approve
/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, LinshanYu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit f51b043 into kubernetes:master Jan 16, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants