-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #8176 and #8209: Add deprecation warning for older k8s versions #8207
Automated cherry pick of #8176 and #8209: Add deprecation warning for older k8s versions #8207
Conversation
As discussed during yesterday's office hours. This should be cherry-picked back to 1.16. We'll need to bump the minor version in the 1.17 and master branches. Once we officially drop support we could make this a sliding window that uses the `kops.Version` variable. I think we could have deprecation warnings for the 2 oldest versions still supported by the kops version, announcing that the n+2 Kops version will no longer support the specified k8s version.
/test pull-kops-e2e-kubernetes-aws-1-16 |
Thanks @rifelpet! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
3 similar comments
/retest |
/retest |
/retest |
Cherry pick of #8176 on release-1.16.
#8176: Add deprecation warning for older k8s versions
For details on the cherry pick process, see the cherry pick requests page.
also cherry picks a typo fix in #8209