Set CLUSTER_NAME env var on amazon-vpc-cni pods #8274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will tag ENIs with `cluster.k8s.amazonaws.com/name`
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
|
/retest |
|
/test pull-kops-e2e-kubernetes-aws |
1 similar comment
|
/test pull-kops-e2e-kubernetes-aws |
mikesplain
approved these changes
Jan 6, 2020
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikesplain, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-kops-e2e-kubernetes-aws |
1 similar comment
|
/test pull-kops-e2e-kubernetes-aws |
|
/retest |
|
/test pull-kops-verify-govet |
|
/retest |
|
/test pull-kops-e2e-kubernetes-aws |
1 similar comment
|
/test pull-kops-e2e-kubernetes-aws |
This was referenced Jan 6, 2020
k8s-ci-robot
added a commit
that referenced
this pull request
Jan 8, 2020
…-origin-release-1.17 Automated cherry pick of #8274: Set CLUSTER_NAME env var on amazon-vpc-cni pods
k8s-ci-robot
added a commit
that referenced
this pull request
Jan 17, 2020
…-origin-release-1.16 Automated cherry pick of #8274: Set CLUSTER_NAME env var on amazon-vpc-cni pods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will tag ENIs with
cluster.k8s.amazonaws.com/nameSupport for this was added back in v1.1.0: aws/amazon-vpc-cni-k8s@c82dc6e so I added it to all manifest versions.
I'll work on exposing the other supported env vars via the cluster spec next.