Don't output empty sections in the manifests #8317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
In our kube-dns manifest for 1.6 we often had an empty section,
normalization converted this to `{}` which causes `kubectl apply` to
fail.
We can simply skip empty objects when outputing.
(The tests are split out for easier cherry-picking, should we choose to)
justinsb
force-pushed
the
clean_up_empty_manifest_sections
branch
from
97bf64b
to
cf5c53c
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This was referenced Jan 12, 2020
k8s-ci-robot
added a commit
that referenced
this pull request
Jan 12, 2020
…-origin-release-1.17 Automated cherry pick of #8317: Don't output empty sections in the manifests
k8s-ci-robot
added a commit
that referenced
this pull request
Jan 18, 2020
…-origin-release-1.16 Automated cherry pick of #8317: Don't output empty sections in the manifests
k8s-ci-robot
added a commit
that referenced
this pull request
Jan 22, 2020
…-origin-release-1.15 Automated cherry pick of #8317: Don't output empty sections in the manifests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our kube-dns manifest for 1.6 we often had an empty section,
normalization converted this to
{}which causeskubectl applyto fail.We can simply skip empty objects when outputing.
Tests are split into a separate commit for easier cherry-picking.