Don't share /etc/hosts when using etcd-manager #8322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
justinsb
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
do-not-merge/work-in-progress
justinsb
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
Thanks, makes sense, good idea. We probably need to update tests for this too though. LGTM but will need another after tests are fixed 😄 /lgtm |
k8s-ci-robot
added
the
lgtm
With etcd-manager the DNS names should only be used by the etcd-manager pod itself, so we don't need to share /etc/hosts with the host. By not sharing we avoid: (1) the temptation to address etcd directly (2) problems of concurrent updates to /etc/hosts being hard from within a container (because locking is difficult across bind mounts) Introducing with kubernetes 1.17 to avoid changing behavior of existing versions.
justinsb
force-pushed
the
dont_map_etcd_manager_hosts
branch
from
544d07f
to
4fe3db7
Compare
k8s-ci-robot
added
size/L
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/test pull-kops-e2e-kubernetes-aws |
1 similar comment
|
/test pull-kops-e2e-kubernetes-aws |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With etcd-manager the DNS names should only be used by the
etcd-manager pod itself, so we don't need to share /etc/hosts with the
host.
By not sharing we avoid:
(1) the temptation to address etcd directly
(2) problems of concurrent updates to /etc/hosts being hard from within a container (because locking is difficult across bind mounts)
Introducing with kubernetes 1.17 to avoid changing behavior of existing versions.