Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code for unsupported Kubernetes versions #8327

Merged
merged 6 commits into from
Jan 15, 2020
Merged

Remove code for unsupported Kubernetes versions #8327

merged 6 commits into from
Jan 15, 2020

Conversation

johngmyers
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 12, 2020
@johngmyers
Copy link
Member Author

/test pull-kops-e2e-kubernetes-aws

@johngmyers
Copy link
Member Author

/retest

@hakman
Copy link
Member

hakman commented Jan 13, 2020

Nice!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2020
@rifelpet
Copy link
Member

looks great!
/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2020
@hakman
Copy link
Member

hakman commented Jan 15, 2020

/test pull-kops-e2e-kubernetes-aws

@rifelpet
Copy link
Member

/test pull-kops-bazel-build

@rifelpet
Copy link
Member

/test pull-kops-e2e-kubernetes-aws

@k8s-ci-robot k8s-ci-robot merged commit 77d6d38 into kubernetes:master Jan 15, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 15, 2020
@johngmyers johngmyers deleted the remove-code branch January 15, 2020 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshbranham joshbranham Awaiting requested review from joshbranham

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@rifelpet rifelpet

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@johngmyers @hakman @rifelpet @k8s-ci-robot