Test package versions as well as hashes #8360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
justinsb
force-pushed
the
check_package_hashes
branch
from
35deec6
to
cc20232
Compare
k8s-ci-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
hakman
reviewed
Jan 17, 2020
nodeup/pkg/model/docker_test.go
Outdated
| if version != expectedVersion { | ||
| return fmt.Errorf("unexpected version, actual=%q, expected=%q", version, expectedVersion) | ||
| } | ||
| } else if strings.HasSuffix(u, ".tgz") { |
There was a problem hiding this comment.
Packages for conatinerd have a tar.gz suffix:
https://github.com/kubernetes/kops/pull/8199/files#diff-ecf61990c0cdda1c13ad07df0440a537R116-R135
Suggested change
| } else if strings.HasSuffix(u, ".tgz") { | |
| } else if strings.HasSuffix(u, ".tgz") || strings.HasSuffix(u, ".tar.gz") { |
hakman
reviewed
Jan 17, 2020
nodeup/pkg/model/docker_test.go
Outdated
| return fmt.Errorf("did not expect version for tgz package") | ||
| } | ||
| } else { | ||
| return fmt.Errorf("unexpected suffix for file (not .rpm or .deb)") |
There was a problem hiding this comment.
Maybe also list .tgz and .tar.gz and the file name.
justinsb
force-pushed
the
check_package_hashes
branch
from
cc20232
to
424b7d4
Compare
Extend the existing "unit" test to check package versions, because some of the docker packages now have a '5:' prefix. Also correct the package versions that didn't have the prefix.
justinsb
force-pushed
the
check_package_hashes
branch
from
424b7d4
to
1d58f16
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the existing "unit" test to check package versions, because
some of the docker packages now have a '5:' prefix.