Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IAMPrefix() for hostedzone #8366

Merged
merged 2 commits into from Jan 21, 2020

Conversation

lazzarello
Copy link
Contributor

fixes #8359 upstream

Tested in us-gov-west-1 zone with the following

$ ./kops create cluster --image=${AMI_NAME} --dns=private --zones=us-gov-west-1a --name=${CLUSTER_NAME}
$ ./kops update cluster ${CLUSTER_NAME} --yes
I0117 13:59:21.485847   14570 dns.go:94] Private DNS: skipping DNS validation
I0117 13:59:22.071985   14570 executor.go:103] Tasks: 0 done / 87 total; 44 can run
I0117 13:59:22.751585   14570 vfs_castore.go:675] Issuing new certificate: "apiserver-aggregator-ca"
I0117 13:59:22.828018   14570 vfs_castore.go:675] Issuing new certificate: "etcd-peers-ca-main"
I0117 13:59:22.830881   14570 vfs_castore.go:675] Issuing new certificate: "ca"
I0117 13:59:22.835241   14570 vfs_castore.go:675] Issuing new certificate: "etcd-manager-ca-main"
I0117 13:59:22.911223   14570 vfs_castore.go:675] Issuing new certificate: "etcd-manager-ca-events"
I0117 13:59:22.958590   14570 vfs_castore.go:675] Issuing new certificate: "etcd-peers-ca-events"
I0117 13:59:22.986829   14570 vfs_castore.go:675] Issuing new certificate: "etcd-clients-ca"
I0117 13:59:23.555176   14570 executor.go:103] Tasks: 44 done / 87 total; 23 can run
I0117 13:59:24.182575   14570 vfs_castore.go:675] Issuing new certificate: "apiserver-aggregator"
I0117 13:59:24.419804   14570 vfs_castore.go:675] Issuing new certificate: "kube-controller-manager"
I0117 13:59:24.429200   14570 vfs_castore.go:675] Issuing new certificate: "kube-scheduler"
I0117 13:59:24.435082   14570 vfs_castore.go:675] Issuing new certificate: "kubecfg"
I0117 13:59:24.459443   14570 vfs_castore.go:675] Issuing new certificate: "kops"
I0117 13:59:24.605755   14570 vfs_castore.go:675] Issuing new certificate: "apiserver-proxy-client"
I0117 13:59:24.744055   14570 vfs_castore.go:675] Issuing new certificate: "master"
I0117 13:59:24.783516   14570 vfs_castore.go:675] Issuing new certificate: "kubelet"
I0117 13:59:24.788647   14570 vfs_castore.go:675] Issuing new certificate: "kube-proxy"
I0117 13:59:24.800117   14570 vfs_castore.go:675] Issuing new certificate: "kubelet-api"
I0117 13:59:25.224904   14570 executor.go:103] Tasks: 67 done / 87 total; 18 can run
I0117 13:59:25.622946   14570 launchconfiguration.go:375] waiting for IAM instance profile "nodes.mission.control" to be ready
I0117 13:59:25.643104   14570 launchconfiguration.go:375] waiting for IAM instance profile "masters.mission.control" to be ready
I0117 13:59:36.227543   14570 executor.go:103] Tasks: 85 done / 87 total; 2 can run
I0117 13:59:37.000449   14570 executor.go:103] Tasks: 87 done / 87 total; 0 can run
I0117 13:59:37.000531   14570 dns.go:155] Pre-creating DNS records
I0117 13:59:37.603519   14570 update_cluster.go:305] Exporting kubecfg for cluster
W0117 13:59:37.843630   14570 create_kubecfg.go:76] Did not find API endpoint for gossip hostname; may not be able to reach cluster
kops has set your kubectl context to mission.control

Cluster is starting.  It should be ready in a few minutes.

Suggestions:
 * validate cluster: kops validate cluster
 * list nodes: kubectl get nodes --show-labels
 * ssh to the master: ssh -i ~/.ssh/id_rsa admin@api.mission.control
 * the admin user is specific to Debian. If not using Debian please use the appropriate user based on your OS.
 * read about installing addons at: https://kops.sigs.k8s.io/operations/addons.

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 17, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @lazzarello!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @lazzarello. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 17, 2020
@lazzarello
Copy link
Contributor Author

/assign @KashifSaadat

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 17, 2020
@johngmyers
Copy link
Member

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 17, 2020
@lazzarello
Copy link
Contributor Author

/retest

1 similar comment
@johngmyers
Copy link
Member

/retest

@lazzarello
Copy link
Contributor Author

It looks like the e2e test is repeatedly failing when trying to upload to GCP. This doesn't seem to be related to my changes.

Unrelated...I tested deletion with my build off this PR and that works as expected. So that's good.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2020
@johngmyers
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2020
@rifelpet
Copy link
Member

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lazzarello, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1cc9507 into kubernetes:master Jan 21, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 21, 2020
k8s-ci-robot added a commit that referenced this pull request Jan 22, 2020
…66-upstream-release-1.17

Automated cherry pick of #8366: use IAMPrefix() for hostedzone
k8s-ci-robot added a commit that referenced this pull request Jan 22, 2020
…66-upstream-release-1.16

Automated cherry pick of #8366: use IAMPrefix() for hostedzone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
5 participants