Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning when using file:// state store #8368

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

rifelpet
Copy link
Member

As discussed during office hours today. This already requires users to opt-in so they should already know what they're doing, but just in case we print this warning.

KOPS_STATE_STORE=file://$(pwd)/state kops update cluster foo.k8s.local
W0117 16:44:05.081437   92040 factory.go:122] The local filesystem state store is not functional for running clusters
I0117 16:44:15.092092   92040 executor.go:103] Tasks: 0 done / 137 total; 55 can run
I0117 16:44:16.268684   92040 executor.go:103] Tasks: 55 done / 137 total; 33 can run
...

This warning is printed on all kops commands that utilize the state store (replace, update, etc.)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2020
Copy link
Contributor

@joshbranham joshbranham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit 412ed66 into kubernetes:master Jan 17, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 17, 2020
k8s-ci-robot added a commit that referenced this pull request Jan 18, 2020
#8368-upstream-release-1.17

Automated cherry pick of #6465: Allow local filesystem state stores #8368: Add a warning when using file:// state store
@rifelpet rifelpet deleted the file-warning branch April 25, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants