Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump etcd-manager to 3.0.20200116 (#8310) #8399

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Bump etcd-manager to 3.0.20200116 (#8310) #8399

merged 1 commit into from
Jan 27, 2020

Conversation

mmerrill3
Copy link
Contributor

Signed-off-by: mmerrill3 michael.merrill@vonage.com

Enable etcdManager version 3.0.20200116 for etcd 3.4.3 access. This is used by default for k8s 1.17. Fixes #8310.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 22, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @mmerrill3. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 22, 2020
@johngmyers
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 22, 2020
johngmyers
johngmyers requested changes Jan 22, 2020
View reviewed changes
pkg/model/components/etcd.go Outdated Show resolved Hide resolved
pkg/model/components/etcd.go Outdated Show resolved Hide resolved
@mmerrill3 mmerrill3 force-pushed the feature/etcd-3.4.3 branch 2 times, most recently from 67db2b6 to dad670e Compare January 23, 2020 15:50
Bump etcd-manager to 3.0.20200116 (kubernetes#8310)
751ce5d 
Signed-off-by: mmerrill3 <michael.merrill@vonage.com>
johngmyers
johngmyers approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@johngmyers johngmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2020
@justinsb
Copy link
Member

Thanks for doing this @mmerrill3 !

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, mmerrill3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2020
@justinsb justinsb mentioned this pull request Jan 26, 2020
Merged
k8s-ci-robot added a commit that referenced this pull request Jan 26, 2020
@k8s-ci-robot
Merge pull request #8410 from justinsb/cherrypick_8399_release-1.17
b9f2c94 
Cherry pick of #8399 onto release-1.17
@justinsb
Copy link
Member

I believe the e2e failure is k8s / test skew, hopefully fixed by kubernetes/test-infra#16029 , not due to this PR.

@rifelpet
Copy link
Member

/test pull-kops-e2e-kubernetes-aws

1 similar comment
@johngmyers
Copy link
Member

/test pull-kops-e2e-kubernetes-aws

@k8s-ci-robot k8s-ci-robot merged commit bff9ad0 into kubernetes:master Jan 27, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 27, 2020
@mmerrill3 mmerrill3 deleted the feature/etcd-3.4.3 branch January 28, 2020 15:24
@rifelpet rifelpet mentioned this pull request Jan 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers johngmyers approved these changes

@joshbranham joshbranham Awaiting requested review from joshbranham

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@justinsb justinsb

@johngmyers johngmyers

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

Add etcd 3.4.3 to etcd manager for kubernetes 1.17
5 participants
@mmerrill3 @k8s-ci-robot @johngmyers @justinsb @rifelpet