-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refuse to read channels with addons with unparseable versions #8408
Conversation
This error is going to be buried deep in the output from channels (in protokube). Can we / should we surface the error even earlier? I'm working on addons anyway (thinking I might be able to show a demo in kops office hours and get some feedback) and would like to make sure that we at least fix it in the revised approach! |
It's at least better than installing something that will always be updated. We could throw a check into |
750e1f4
to
a2bc9cc
Compare
I believe the e2e failure is k8s / test skew, hopefully fixed by kubernetes/test-infra#16029 , not due to this PR. |
/test pull-kops-e2e-kubernetes-aws |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ensure such things get noticed early.
(Having lost half a day due to such a thing.)