Update AWS IAM Authenticator to 0.5.0 #8423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
rdrgmnzs
reviewed
Jan 27, 2020
upup/models/cloudup/resources/addons/authentication.aws/k8s-1.12.yaml.template
Outdated
Show resolved
Hide resolved
rifelpet
force-pushed
the
aws-authenticator-update
branch
from
3a66eed
to
c0b4f62
Compare
johngmyers
reviewed
Jan 28, 2020
upup/models/cloudup/resources/addons/authentication.aws/k8s-1.12.yaml.template
Outdated
Show resolved
Hide resolved
rifelpet
force-pushed
the
aws-authenticator-update
branch
from
c0b4f62
to
ccabe51
Compare
k8s-ci-robot
added
size/L
|
/hold for discussion in kubernetes-sigs/aws-iam-authenticator#287 |
k8s-ci-robot
added
the
do-not-merge/hold
|
/test all |
k8s-ci-robot
added
the
needs-rebase
I merged changes from these manifests: https://github.com/kubernetes-sigs/aws-iam-authenticator/blob/v0.5.0/deploy/example.yaml https://github.com/kubernetes-sigs/aws-iam-authenticator/blob/v0.5.0/deploy/iamidentitymapping.yaml The new version supports replacing the configmap with a IAMIdentityMapping custom resource, but the --backend-mode command argument isnt yet exposed through the kops API, so it will still only use configmaps. We can expose a BackendMode API field in a followup PR.
rifelpet
force-pushed
the
aws-authenticator-update
branch
from
ccabe51
to
32e6a6b
Compare
k8s-ci-robot
removed
the
needs-rebase
|
/test all |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This was referenced Feb 13, 2020
k8s-ci-robot
added a commit
that referenced
this pull request
Feb 13, 2020
…-origin-release-1.16 Automated cherry pick of #8423: Update AWS IAM Authenticator to 0.5.0
k8s-ci-robot
added a commit
that referenced
this pull request
Feb 13, 2020
…-origin-release-1.17 Automated cherry pick of #8423: Update AWS IAM Authenticator to 0.5.0
This was referenced Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
I merged changes from these manifests:
The new version supports replacing the ConfigMap with an IAMIdentityMapping custom resource, but the
--backend-modecommand argument isnt yet exposed through the kops API, so it will still only use configmaps. We can expose a BackendMode API field in a followup PR.Since I know you also use it...
/cc @rdrgmnzs