Add an EnvVar type to the API #8455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Jan 31, 2020
|
/test pull-kops-e2e-kubernetes-aws |
This was copied from the k8s API [0] with the ValueFrom field removed for simplicity. It will be used by the aws-vpc-cni provider and etcd [0] https://github.com/kubernetes/api/blob/bb84ecda436d0529a0ca484be5cafd6a42793ccb/core/v1/types.go#L1827-L1846
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
rdrgmnzs
pushed a commit
to rdrgmnzs/kops
that referenced
this pull request
Feb 10, 2020
rdrgmnzs
added a commit
to rdrgmnzs/kops
that referenced
this pull request
Feb 10, 2020
rdrgmnzs
added a commit
to rdrgmnzs/kops
that referenced
this pull request
Feb 21, 2020
rdrgmnzs
added a commit
to rdrgmnzs/kops
that referenced
this pull request
Feb 21, 2020
rdrgmnzs
added a commit
to rdrgmnzs/kops
that referenced
this pull request
Mar 2, 2020
rdrgmnzs
added a commit
to rdrgmnzs/kops
that referenced
this pull request
Mar 12, 2020
rdrgmnzs
added a commit
to rdrgmnzs/kops
that referenced
this pull request
Apr 26, 2020
granular-ryanbonham
pushed a commit
to granular-ryanbonham/kops
that referenced
this pull request
May 20, 2020
granular-ryanbonham
pushed a commit
to granular-ryanbonham/kops
that referenced
this pull request
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was copied from the k8s API with the ValueFrom field removed for simplicity.
It will be used by the amazon-vpc-cni provider and etcd
As discussed during office hours today.