Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update godoc.org references to use pkg.go.dev #8460

Merged
merged 1 commit into from
Feb 1, 2020

Conversation

rifelpet
Copy link
Member

@rifelpet rifelpet commented Feb 1, 2020

pkg.go.dev will soon replace godoc.org. The main advantage of pkg.go.dev is that it is module-aware and version-aware, so one can view documentation for previous kops versions.

The only remaining references to godoc.org are these status widgets, which I dont believe are yet supported on pkg.go.dev:

grep -r godoc.org . | grep -v vendor
./docs/index.md:[GoDoc Widget]: https://godoc.org/k8s.io/kops?status.svg
./README.md:[GoDoc Widget]: https://godoc.org/k8s.io/kops?status.svg
./README-ES.md:[GoDoc Widget]: https://godoc.org/k8s.io/kops?status.svg

/area documentation

fixes #8371

@k8s-ci-robot k8s-ci-robot added area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2020
@johngmyers
Copy link
Member

/retest

@johngmyers
Copy link
Member

/retest
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit d70cc9e into kubernetes:master Feb 1, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 1, 2020
@rifelpet rifelpet deleted the godev branch August 6, 2020 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update API reference docs to use go.dev
3 participants