-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit test for pkg/jsonutils/streamwriter.go #8475
Add unit test for pkg/jsonutils/streamwriter.go #8475
Conversation
Hi @tiendc. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@tiendc the issue with the netlify jobs has been fixed on master so you'll need to rebase from master in order to get them to work. |
Signed-off-by: Dao Cong Tien <tiendc@vn.fujitsu.com>
Thanks. |
Thanks for the contribution! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet, tiendc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Dao Cong Tien tiendc@vn.fujitsu.com