Move cloudbuild.yaml to repo root #8505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
|
/retest Hopefully fixed by #8506? |
|
I think you might need to rebase to pick up the netlify fix? |
This file is used by the push-to-staging postsubmit job that builds images and pushes them to a staging repo. When it was originally added, my theory for why the job was failing [0] is that we were only uploading the ci/postsubmit/push-to-staging directory to GCS for use in cloudbuild, when in reality we need to push the entire kops repo so it can run `make kops-controller-push`. A while back I had updated the job to use the repo root but hadnt created the cloudbuild.yaml file there yet, so instead we've been getting a cloudbuild.yaml not found error [1]. This moves the cloudbuild.yaml into the repo root so that the current job configuration will recognize it and hopefully be able to run `make kops-controller-push` in GCB. [0] https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/kops-postsubmit-push-to-staging/1209130004504383489 [1] https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/kops-postsubmit-push-to-staging/1213230826582446081
k8s-ci-robot
removed
the
lgtm
|
done :) |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@justinsb the postsubmit job now takes 3 minutes but still fails without any output: I'm guessing GCB is outputting an error but it is not making its way back into the prow job. Any chance you can take a look at the GCB error? |
|
ah nevermind it turns out the logs are public.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file is used by the push-to-staging postsubmit job that builds images and pushes them to a staging repo.
When it was originally added, my theory for why the job was failing is that we were only uploading the ci/postsubmit/push-to-staging directory to GCS for use in cloudbuild, when in reality we need to upload the entire kops repo so it can run
make kops-controller-push.A while back I had updated the job to use the repo root but hadn't created the cloudbuild.yaml file there yet, so instead we've been getting a cloudbuild.yaml not found error.
This PR moves the cloudbuild.yaml into the repo root so that the current job configuration will recognize it and hopefully be able to run
make kops-controller-pushin GCB.