Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vendoring] Update google libs to latest #8516

Merged
merged 1 commit into from
Feb 9, 2020
Merged

[vendoring] Update google libs to latest #8516

merged 1 commit into from
Feb 9, 2020

Conversation

geojaz
Copy link
Member

@geojaz geojaz commented Feb 9, 2020

Our GCE libs are sad and old. Google recently released v0.17.0.
This is part 1 of 2 where I will attempt to swap compute/v0.beta for compute/v1 (GCE)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 9, 2020
@geojaz geojaz added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geojaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2020
@geojaz geojaz mentioned this pull request Feb 9, 2020
Closed
@geojaz geojaz added the area/gce label Feb 9, 2020
@geojaz geojaz changed the title Updates googleapis to latest [vendoring] Update google libs to latest Feb 9, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2020
@geojaz
Copy link
Member Author

geojaz commented Feb 9, 2020

/test pull-kops-e2e-kubernetes-aws
seems like a flake? since these changes should only affect gce

@johngmyers
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2020
@geojaz
Copy link
Member Author

geojaz commented Feb 9, 2020

We're definitely flaking since this is a totally different failure than last run. I have added a PR to bump our ginkgo.flakeAttempts to 2 (from 1) on the kops e2e tests here kubernetes/test-infra#16201 that I hope will help this sort of thing...

@johngmyers
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 6b4b003 into kubernetes:master Feb 9, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 9, 2020
@geojaz geojaz deleted the update_gce_lib branch February 9, 2020 20:37
@geojaz geojaz mentioned this pull request Apr 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshbranham joshbranham Awaiting requested review from joshbranham

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@johngmyers johngmyers

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/gce cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@geojaz @k8s-ci-robot @johngmyers