Fix Machine types vcpus #8522
Merged
Fix Machine types vcpus #8522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
mikesplain
force-pushed
the
fix_machines_types
branch
from
df59327
to
685ca73
Compare
|
definitely looking forward to switching to ec2.DescribeInstanceTypes. We could get rid of this file entirely right? And wouldn't need to do an sdk update and kops release in order to recognize new instance types? /lgtm |
k8s-ci-robot
added
the
lgtm
|
Agreed, yes I believe so, if we want to trust the APIs real time. Previously we used cluster-autoscaler as an example. I'll see if they've moved over! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why this changed in #8128 but I'm going to look into modernizing this with the new api soon.