Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #8497: Mark dns-controller and kops-controller as non-root #8523

Conversation

johngmyers
Copy link
Member

Cherry pick of #8497 on release-1.17.

#8497: Mark dns-controller and kops-controller as non-root

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Feb 11, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 11, 2020
@mikesplain
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2020
@johngmyers
Copy link
Member Author

/retest

@geojaz
Copy link
Member

geojaz commented Feb 11, 2020

/lgtm

@johngmyers
Copy link
Member Author

/retest

@rifelpet
Copy link
Member

I don’t think the PR that changed the kops-controller user was cherrypicked to 1.17

https://github.com/kubernetes/kops/blob/release-1.17/cmd/kops-controller/BUILD.bazel

@johngmyers
Copy link
Member Author

Ah, so many patches.
Do we want to cherrypick the user changes to 1.17? In any case we won't be able to cherrypick this until there is an intervening release.

@johngmyers johngmyers closed this Feb 11, 2020
@johngmyers johngmyers deleted the automated-cherry-pick-of-#8497-upstream-release-1.17 branch February 11, 2020 04:59
@k8s-ci-robot
Copy link
Contributor

@johngmyers: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kops-e2e-kubernetes-aws-1-17 32d58b6 link /test pull-kops-e2e-kubernetes-aws-1-17

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rifelpet
Copy link
Member

I have no opinion on whether we cherry-pick it. Luckily the hostPath logging work was never cherry-picked back to 1.17 or 1.16 so we don't need to worry about cherry-pick the revert if we do choose to cherry-pick the user change PR and this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants