-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #8497: Mark dns-controller and kops-controller as non-root #8523
Conversation
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/lgtm |
/retest |
I don’t think the PR that changed the kops-controller user was cherrypicked to 1.17 https://github.com/kubernetes/kops/blob/release-1.17/cmd/kops-controller/BUILD.bazel |
Ah, so many patches. |
@johngmyers: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I have no opinion on whether we cherry-pick it. Luckily the hostPath logging work was never cherry-picked back to 1.17 or 1.16 so we don't need to worry about cherry-pick the revert if we do choose to cherry-pick the user change PR and this. |
Cherry pick of #8497 on release-1.17.
#8497: Mark dns-controller and kops-controller as non-root
For details on the cherry pick process, see the cherry pick requests page.