Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotinst: Add OWNERS file to Spotinst specific packages #8533

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

liranp
Copy link
Contributor

@liranp liranp commented Feb 12, 2020

We propose that we add OWNERS file to Spotinst specific packages in order to decrease the time of development lifecycle (for example, please see the following PRs: #7040, #7252 and #8294), so we can review and approve things ourselves. For now, these files contain only one approver (me), but we will add more contributors later.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 12, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @liranp. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 12, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Feb 12, 2020
@rifelpet
Copy link
Member

Hi @liranp thanks for taking this initiative! It looks like you'll need to join the kubernetes org before you can be added to OWNERS files. Links are above

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 13, 2020
@liranp
Copy link
Contributor Author

liranp commented Feb 13, 2020

@rifelpet Thanks! I've just noticed that one of the requirements is to be sponsored by two existing reviewers. Is it okay to mention you guys as my sponsors?

@rifelpet
Copy link
Member

yes, I'll be happy to sponsor you!

@liranp
Copy link
Contributor Author

liranp commented Feb 13, 2020

Thank you so much, @rifelpet!

@justinsb, @chrisz100 Is it okay to mention one of you as well?

@mikesplain
Copy link
Contributor

@liranp I’m happy to sponsor you, mention me and we can get this process started.

@liranp
Copy link
Contributor Author

liranp commented Feb 17, 2020

Thank you so much, @mikesplain!

@liranp
Copy link
Contributor Author

liranp commented Feb 17, 2020

I've opened an issue against the kubernetes/org repo (kubernetes/org#1634).

@rifelpet
Copy link
Member

/verify-owners

1 similar comment
@liranp
Copy link
Contributor Author

liranp commented Feb 19, 2020

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Feb 19, 2020
@mikesplain
Copy link
Contributor

Thanks for taking this on! We look forward to your future contributions!

/retest
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 19, 2020
@chrisz100
Copy link
Contributor

/approve
/lgtm

welcome!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisz100, liranp, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chrisz100,mikesplain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9cbbdd8 into kubernetes:master Feb 19, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 19, 2020
@liranp liranp deleted the fix-spotinst-owners branch February 23, 2020 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants