-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spotinst: Add support for blacklisting or whitelisting instance types in Ocean #8549
Spotinst: Add support for blacklisting or whitelisting instance types in Ocean #8549
Conversation
Hi @liranp. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
d20fbf3
to
cd1d474
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liranp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm @liranp on a side note, it would be great if we could setup some integration tests that use SpotInst and Terraform. You can see examples here and they get called here. I tried creating one myself a while back but ran into issues because we dont have a "MockCloud" for SpotInst the same way that we do for AWS. I'm going to be making some changes to the terraform code soon and having integration tests that cover the other cloud providers would help immensely. I can open a GH issue if that helps. |
@rifelpet Sure, I‘ll take care of that as soon as possible. Thank you! |
This PR adds support for blacklisting or whitelisting instance types in Ocean.