Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cilium docs with note about eni and bpf nodeport #8551

Merged
merged 3 commits into from
Mar 13, 2020
Merged

Update cilium docs with note about eni and bpf nodeport #8551

merged 3 commits into from
Mar 13, 2020

Conversation

olemarkus
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 13, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @olemarkus. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 13, 2020
@hakman
Copy link
Member

hakman commented Feb 13, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 13, 2020
rifelpet
rifelpet reviewed Feb 14, 2020
View reviewed changes
docs/networking.md Outdated Show resolved Hide resolved
johngmyers
johngmyers requested changes Feb 14, 2020
View reviewed changes
docs/networking.md Show resolved Hide resolved
docs/networking.md Outdated Show resolved Hide resolved
docs/networking.md Outdated Show resolved Hide resolved
docs/networking.md

As of Kops 1.18 you can safely enable Cilium NodePort.

In this mode, the cluster is fully functional without kube-proxy, with Cilium replacing kube-proxy's NodePort implementation using BPF.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In this mode, the cluster is fully functional without kube-proxy, with Cilium replacing kube-proxy's NodePort implementation using BPF.
In this mode the cluster is fully functional without kube-proxy, with Cilium replacing kube-proxy's NodePort implementation using BPF.

@olemarkus olemarkus force-pushed the docs-networking-cilium-bpf-eni branch from 976e409 to e0ed5a7 Compare February 14, 2020 06:15
johngmyers
johngmyers requested changes Feb 15, 2020
View reviewed changes
docs/networking.md

##### Enabling BPF NodePort

As of Kops 1.18 you can safely enable Cilium NodePort.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm skeptical of the value of documenting in which version each feature was added. This should just state what NodePort is and how one can enable it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this would be the most helpful since Kops doesn't have versioned docs. If this goes in, it would reference features that doesn't exists.

docs/networking.md
$ kops update cluster myclustername.mydns.io --yes
As of Kops 1.18, you can have Cilium provision AWS managed adresses and attach them directly to Pods much like Lyft VPC and AWS VPC. See [the Cilium docs for more information](https://docs.cilium.io/en/v1.6/concepts/ipam/eni/)

When using ENI IPAM you need to disable masquerading in Cilium as well.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When using ENI IPAM you need to disable masquerading in Cilium as well.
When using ENI IPAM you need to disable masquerading in Cilium unless you have no NAT/internet gateway to masquerade the ENI addresses to external networks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR went in with forcing masquerading to be disabled.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems unfortunate. I had thought we had discovered a use case for not forcing it.

docs/networking.md Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 25, 2020
@olemarkus olemarkus force-pushed the docs-networking-cilium-bpf-eni branch from c29907b to 011991d Compare February 25, 2020 19:23
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 25, 2020
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 3, 2020
@olemarkus olemarkus force-pushed the docs-networking-cilium-bpf-eni branch from 011991d to cd29da7 Compare March 10, 2020 14:53
@rifelpet
Copy link
Member

This looks good to me, we can always iterate on it in future PRs

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1ab724e into kubernetes:master Mar 13, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 13, 2020
@olemarkus olemarkus deleted the docs-networking-cilium-bpf-eni branch March 25, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet left review comments

@johngmyers johngmyers johngmyers requested changes

@joshbranham joshbranham Awaiting requested review from joshbranham

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@olemarkus @k8s-ci-robot @hakman @rifelpet @johngmyers