Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.16 Release Notes - Add Known CoreDNS metrics regression #8588

Closed

Conversation

gjtempleton
Copy link
Member

@gjtempleton gjtempleton commented Feb 19, 2020

Replacement for #8587

As per discussion at office hours.

I've followed the style and syntax as much as possible from upstream k/k given we haven't had known issues blocks since 1.6, open to feedback especially as it doesn't actually apply to all releases in the 1.16 train.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gjtempleton
To complete the pull request process, please assign granular-ryanbonham
You can assign the PR to them by writing /assign @granular-ryanbonham in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rifelpet
Copy link
Member

Any reason this shouldn't also be mentioned in 1.17 and 1.18 release notes? Are we hoping to have upgraded to 1.6.7 in those branches?

@rajansandeep
Copy link
Contributor

The coredns version 1.6.7 is now made available in gcr.io (This would be the version in upstream k/k 1.18)

$ docker pull k8s.gcr.io/coredns:1.6.7
1.6.7: Pulling from coredns
Digest: sha256:2c8d61c46f484d881db43b34d13ca47a269336e576c81cf007ca740fa9ec0800
Status: Downloaded newer image for k8s.gcr.io/coredns:1.6.7

@gjtempleton
Copy link
Member Author

I was assuming that the 1.6.7 publish to k8s.gcr.io would happen before 1.17 and 1.18 hit GA. Seems it happened even faster than anticipated.

I guess in that case time to close this PR and re-pick the updates into the release branches then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants