Add unit test for pkg/apis/kops/util/labels.go

[tiendc]

Signed-off-by: Dao Cong Tien tiendc@vn.fujitsu.com

[k8s-ci-robot]

Hi @tiendc. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hakman]

/ok-to-test

[rifelpet]

nit: can we use node instead of slave here? Kops uses node so it probably makes sense to match that.

kops/pkg/nodelabels/builder.go

Line 31 in 942c891

RoleLabelNode16 = "node-role.kubernetes.io/node"

[rifelpet]

/lgtm
/approve
Thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet, tiendc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rifelpet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hakman]

@tiendc for some reason I get random failure for this test. Any ideas?

--- FAIL: TestGetNodeRole (0.00s)
    --- PASS: TestGetNodeRole/RoleNone (0.00s)
    --- FAIL: TestGetNodeRole/RoleNewerLabel (0.00s)
        labels_test.go:72: Got role "master", expected "node"
    --- PASS: TestGetNodeRole/RoleOlderLabel (0.00s)

https://api.travis-ci.org/v3/job/653363472/log.txt

[tiendc]

@tiendc for some reason I get random failure for this test. Any ideas?

--- FAIL: TestGetNodeRole (0.00s)
    --- PASS: TestGetNodeRole/RoleNone (0.00s)
    --- FAIL: TestGetNodeRole/RoleNewerLabel (0.00s)
        labels_test.go:72: Got role "master", expected "node"
    --- PASS: TestGetNodeRole/RoleOlderLabel (0.00s)

https://api.travis-ci.org/v3/job/653363472/log.txt

I think the reason is Go does not keep the order when iterate over a map. I can deliver a fix, but I'm not sure whether I should create a new PR or just delete this brand. Do you have any suggestion?

[hakman]

I think the reason is Go does not keep the order when iterate over a map. I can deliver a fix, but I'm not sure whether I should create a new PR or just delete this brand. Do you have any suggestion?

Thanks. New PR would be perfect.

[tiendc]

I think the reason is Go does not keep the order when iterate over a map. I can deliver a fix, but I'm not sure whether I should create a new PR or just delete this brand. Do you have any suggestion?

Thanks. New PR would be perfect.

Fixed by #8604

[hakman]

Very fast :). Thanks!