Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail cluster validation if a master missing kube-controller-manager #8600

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Fail cluster validation if a master missing kube-controller-manager #8600

merged 1 commit into from
Feb 21, 2020

Conversation

johngmyers
Copy link
Member

This should fix the known cause of cluster validation flapping.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 21, 2020
@johngmyers
Copy link
Member Author

@zetaab I'd appreciate it if you could give this a try.

zetaab
zetaab approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@zetaab zetaab left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

I am not using master branch in our clusters, currently 1.17.0-alpha.4. So I cannot say yet does it help.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit 00f4e80 into kubernetes:master Feb 21, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 21, 2020
@johngmyers johngmyers deleted the validate-controller-manager branch February 21, 2020 17:07
@johngmyers johngmyers mentioned this pull request Feb 21, 2020
Merged
k8s-ci-robot added a commit that referenced this pull request Feb 25, 2020
@k8s-ci-robot
Merge pull request #8606 from johngmyers/automated-cherry-pick-of-#7925-
6214ffd 
#8039-#8159-#8600-upstream-release-1.17

Automated cherry pick of #7925: Extract the list of instance groups earlier in validation #8039: Vendor github.com/stretchr/testify/require #8159: Determine node role from instancegroup spec #8600: Fail cluster validation if a master missing
@johngmyers
Copy link
Member Author

@zetaab This has been backported into 1.17.0-beta.1. I'd appreciate it if you could let me know how it is working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zetaab zetaab zetaab approved these changes

@joshbranham joshbranham Awaiting requested review from joshbranham

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@zetaab zetaab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johngmyers @k8s-ci-robot @zetaab