-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete launch templates when using EnableLaunchTemplates #8639
Delete launch templates when using EnableLaunchTemplates #8639
Conversation
a341f73
to
cda5611
Compare
/test pull-kops-e2e-kubernetes-aws |
The other thing this does is change from comparing against the |
cda5611
to
7b5a471
Compare
Thanks for noticing the typo. I just pushed a fix. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I created a new E2E job for launch templates: https://testgrid.k8s.io/sig-cluster-lifecycle-kops#kops-aws-launchtemplates And confirmed that the LT is not getting deleted on cluster teardown: https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/e2e-kops-aws-misc-launchtemplates/1233770692407726083#1:build-log.txt%3A69891 so we can use this job to confirm this PR fixes the problem. |
Setting the feature flag
EnableLaunchTemplates=true
make kops use Launch Templates instead of Launch Configurations to create the ASGs.Launch Templates implementation in Kops is derived from the Mixed Instance Policy feature, but requires a few tweaks. One of it is that security groups are declared for the primary network interface instead of the SecurityGroups field. For this reason, the delete mechanism is not finding these launch templates.