-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UT for util/pkg/proxy/proxy.go #8640
Add UT for util/pkg/proxy/proxy.go #8640
Conversation
Hi @tiendc. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Dao Cong Tien <tiendc@vn.fujitsu.com>
/ok-to-test |
Port: 1234, | ||
}, | ||
}, | ||
// TODO: The output seems a little bit weird for this case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to catch it in validation, but this seems a reasonable translation at this layer!
Thanks @tiendc - looks great! I do wonder whether people expect https_proxy to use https, but this is a good test that shows the current state of the mapping. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, tiendc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
Signed-off-by: Dao Cong Tien tiendc@vn.fujitsu.com