When nodeport is enabled, use strict kube-proxy-replacement to ensure…

[olemarkus]

… cilium fully replaces kube-proxy

[k8s-ci-robot]

Hi @olemarkus. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[olemarkus]

Without this, service forwarding fails on newer Cilium versions.

/bug

[rifelpet]

/ok-to-test

[diegocn]

• Tested @olemarkus's branch and I was able to spin up a running cluster with cilium 1.7.0 and without kube-proxy.
• I can see some logs on cilium-agents related to some sort of failure on BPF probe even with the host/node AMI with BPF enabled and mounted:
  level=warning msg="BPF system config check: NOT OK." error="CONFIG_BPF kernel parameter is required" subsys=linux-datapath
• Before this patch kops-controller was not able to reach kubernetes-api. Now it's running as expected.

[olemarkus]

See cilium/cilium#10256 regarding the config check error. It is harmless

[hakman]

Suggested change

	{{ if .EnableNodePort }}
	kube-proxy-replacement: strict
	{{ end }}
	kube-proxy-replacement: "{{- if .EnableNodePort -}}strict{{- else -}}probe{{- end -}}"

[olemarkus]

I would perhaps go for kube-proxy-replacement: disabled. it is a bit easier to understand what is happening if one is explicit.

[hakman]

Sounds even better to me.

[rifelpet]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rifelpet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hakman]

/lgtm

[johngmyers]

@olemarkus This looks like the prime suspect in breaking the kops-aws-cni-cilium e2e test. Could you take a look?

[olemarkus]

yep