-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support apiserver --kubelet-certificate-authority flag #8661
Conversation
@@ -315,6 +315,8 @@ type KubeAPIServerConfig struct { | |||
RuntimeConfig map[string]string `json:"runtimeConfig,omitempty" flag:"runtime-config"` | |||
// KubeletClientCertificate is the path of a certificate for secure communication between api and kubelet | |||
KubeletClientCertificate string `json:"kubeletClientCertificate,omitempty" flag:"kubelet-client-certificate"` | |||
// KubeletCertificateAuthority is the path of a certificate authority for secure communication between api and kubelet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
// KubeletCertificateAuthority is the path of a certificate authority for secure communication between api and kubelet | |
// KubeletCertificateAuthority is the path of a certificate authority for secure communication between api and kubelet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update it
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet, tanjunchen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes##8546
/cc @rifelpet