Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the cloud provider that supports it, a
maxSurge
of 1 (and thusmaxUnavailable
of 0) is a better default thanmaxSurge
of 0 andmaxUnavailable
of 1. Nodes will still be drained one at a time, but the pods evicted from the first node won't have to be replaced on an old node and get evicted again.The only downside I can think of would require a rather contrived situation: a workload that is deployed with a DaemonSet instead of a Deployment or StatefulSet and which cannot tolerate having the resulting surged pod.
/area rolling-update