-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] add link for Service Account Token Volumes #8688
Conversation
Signed-off-by: Jonathan Meyers <jonathan@cybrary.it>
Hi @jmymy. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/assign @geojaz |
Am I missing a step that generates the page? Seem to be getting a 404 on the netlify build. Assuming the release hasn't been cut for my other PR yet so the page doesn't exist in the branch this test is building. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine but the preview won’t work since this branch doesn’t contain that page. I believe you likely branched off master with this change before your other PR merged.
Either way, I’ll approve for now and we can make changes in future PRs. Thanks!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmymy, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add nav for new docs page. #8680
CC: @mikesplain
Signed-off-by: Jonathan Meyers jonathan@cybrary.it