Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor integration tests #8737

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Refactor integration tests #8737

merged 1 commit into from
Mar 31, 2020

Conversation

rifelpet
Copy link
Member

closes #8736

This refactors the integration tests so that it is easier to add new variables to tests in the future including the ability to provide default values.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 13, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2020
@johngmyers
Copy link
Member

Could we land #8431 first? That's going to massively conflict.

@rifelpet
Copy link
Member Author

yes I'm fine with that

/hold for #8431

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2020
@rifelpet rifelpet mentioned this pull request Mar 14, 2020
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 16, 2020
@rifelpet rifelpet mentioned this pull request Mar 26, 2020
Closed
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2020
@rifelpet
Copy link
Member Author

/hold cancel

This is ready for review

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 30, 2020
This was referenced Mar 30, 2020
Merged
Merged
@hakman
Copy link
Member

hakman commented Mar 31, 2020

runTestGCE and runTestAWS are referring to Terraform, right. Maybe it's a good time to make this clear in the name.

@rifelpet
Copy link
Member Author

Updated to use runTestTerraformAWS and runTestTerraformGCE 👍

@hakman
Copy link
Member

hakman commented Mar 31, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2e57aaa into kubernetes:master Mar 31, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 31, 2020
@rifelpet rifelpet deleted the integration-test-refactor branch August 6, 2020 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshbranham joshbranham Awaiting requested review from joshbranham

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

Refactor Integration Tests
4 participants
@rifelpet @k8s-ci-robot @johngmyers @hakman