Fix template for kube-router v0.4.0 #8742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/cc @rifelpet |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
I see this is currently has the milestone for kops 1.18 but I am pretty sure this needs to get back ported into 1.16 and 1.17. If we don't do a backport here then upgrading the clusters is going to be quite challenging. |
This was referenced Apr 7, 2020
|
Thanks for the reminder @UnderMyBed. I opened the necessary cherrypicks. |
k8s-ci-robot
added a commit
that referenced
this pull request
Apr 7, 2020
k8s-ci-robot
added a commit
that referenced
this pull request
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8735 uses the kubeadm-kuberouter.yaml template as base, but it's broken. To fix it, I am trying to use the generic-kuberouter.yaml.
The only real difference is removing
--kubeconfig=/var/lib/kube-router/kubeconfigfrom args. The rest of changes are whitespace to make the diff easier next time.My setup seems broken as I cannot get this to work on my end. Hoping that after this change, the e2e will start working again:
https://testgrid.k8s.io/sig-cluster-lifecycle-kops#kops-aws-cni-kuberouter