Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a gce-service-account flag so you BYO service-account #8761

Merged
merged 2 commits into from
Apr 5, 2020
Merged

Adds a gce-service-account flag so you BYO service-account #8761

merged 2 commits into from
Apr 5, 2020

Conversation

geojaz
Copy link
Member

@geojaz geojaz commented Mar 17, 2020

This will need #8760 . It lets you specify the email of a service account with which you'd like your instances to be launched. This is part of trying to steer the GCE support closer to GCE native/best practices.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/api area/documentation labels Mar 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geojaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2020
@geojaz
Copy link
Member Author

geojaz commented Mar 17, 2020

/hold
I'll add a test with the flag set both directions

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2020
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 17, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 18, 2020
@geojaz
Copy link
Member Author

geojaz commented Mar 19, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2020
rifelpet
rifelpet reviewed Mar 19, 2020
View reviewed changes
tests/integration/create_cluster/gce_byo_sa/options.yaml
Cloud: gce
KubernetesVersion: v1.15.6-beta.1
Project: testproject
GCEServiceAccount: test-account@testproject.iam.gserviceaccount.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to add this gce_byo_sa test case to cmd/kops/create_cluster_integration_test.go. I'd also expect to see test-account@testproject.iam.gserviceaccount.com in some expected output values for this test somewhere... in a kubernetes.tf or in expected-v1alpha2.yaml ?

rifelpet
rifelpet reviewed Mar 19, 2020
View reviewed changes
pkg/apis/kops/cluster.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2020
@geojaz
Adds a gce-service-account flag so you BYO service-account
b3d65ff 
Generated code and some cleanup

Not sure where that code went

Tests for service account

fixes case on gceserviceaccount
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 5, 2020
@geojaz
Adds some initial tests. Fixes some logic
c59314a 
Need to fix service account implementation first

Fixing tests and iterating on the serviceaccount logic

Run the gce_byo_sa test
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 5, 2020
@rifelpet
Copy link
Member

rifelpet commented Apr 5, 2020

looks good now, thanks for the work! it'll be great to eventually support this at the instance group level too.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit 311c596 into kubernetes:master Apr 5, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Apr 5, 2020
@geojaz geojaz mentioned this pull request Apr 5, 2020
Closed
@geojaz geojaz deleted the gce_byo_sa branch April 5, 2020 21:22
@geojaz
Copy link
Member Author

geojaz commented Apr 5, 2020

you bet! thanks for helping me keep this active. we should definitely support IG level configs in next iteration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinpercy robinpercy robinpercy left review comments

@rifelpet rifelpet rifelpet left review comments

@joshbranham joshbranham Awaiting requested review from joshbranham

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@geojaz @k8s-ci-robot @rifelpet @robinpercy