Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for OpenStack Octavia AllowedCIDRs #8762

Merged
merged 2 commits into from
Mar 18, 2020

Conversation

zetaab
Copy link
Member

@zetaab zetaab commented Mar 17, 2020

fixes #8383

@kciredor do you have possibility to test this? Do you know how to compile kops manually, or you want that I will compile it? If yes, what OS do you use

This needs to be tested in following use-cases:

  • Old octavia new cluster
  • Old octavia update sec group rules for api
  • Update from old octavia to new octavia (should delete old security group)
  • New octavia new cluster
  • New octavia update sec group rules for api

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 17, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/openstack Issues or PRs related to openstack provider labels Mar 17, 2020
@kciredor
Copy link

Awesome @zetaab, moving fast!

Yes I'm used to compiling/patching kops so no problem there. Will let you know as soon as I can!

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 17, 2020
@kciredor
Copy link

Works great!

I've just tested it on a new/clean cluster by adding/removing ip ranges (kops edit cluster + kops update cluster --yes) and making API calls in between.

Could this still be merged into the 1.17 release branch which is currently beta 1? That would be cool.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 17, 2020
@zetaab
Copy link
Member Author

zetaab commented Mar 17, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2020
Copy link
Contributor

@chrisz100 chrisz100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks @zetaab :-)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisz100, zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 06823cf into kubernetes:master Mar 18, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 18, 2020
@zetaab zetaab deleted the allowedcidrs branch March 19, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenStack: Octavia loadbalancer requires ".AllowedCIDRs" instead of Security Group
4 participants