-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for OpenStack Octavia AllowedCIDRs #8762
Conversation
Awesome @zetaab, moving fast! Yes I'm used to compiling/patching kops so no problem there. Will let you know as soon as I can! |
Works great! I've just tested it on a new/clean cluster by adding/removing ip ranges (kops edit cluster + kops update cluster --yes) and making API calls in between. Could this still be merged into the 1.17 release branch which is currently beta 1? That would be cool. |
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks @zetaab :-)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrisz100, zetaab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixes #8383
@kciredor do you have possibility to test this? Do you know how to compile kops manually, or you want that I will compile it? If yes, what OS do you use
This needs to be tested in following use-cases:
/hold