Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotinst: Upgrade the Spotinst controller to version 1.0.57 #8770

Merged

Conversation

liranp
Copy link
Contributor

@liranp liranp commented Mar 18, 2020

This PR upgrades the Spotinst controller to version 1.0.57 and aligns all resources with the corresponding Helm chart.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 18, 2020
@rifelpet
Copy link
Member

:( we rely on ifconfig.co to get our public ip address in e2e jobs. @hakman has an improvement for this here: kubernetes/test-infra#16834 that we'll need merged. I suppose we can periodically retry this e2e job too.

@liranp
Copy link
Contributor Author

liranp commented Mar 18, 2020

/test pull-kops-e2e-kubernetes-aws

@rifelpet
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liranp, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2020
@liranp
Copy link
Contributor Author

liranp commented Mar 18, 2020

@rifelpet Thank you so much for reviewing this!

@k8s-ci-robot k8s-ci-robot merged commit a92ce16 into kubernetes:master Mar 18, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 18, 2020
@liranp liranp deleted the feature-spotinst-controller-v1.0.57 branch March 18, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants