Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to bazel 2.2.0 #8790

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Upgrade to bazel 2.2.0 #8790

merged 1 commit into from
Mar 24, 2020

Conversation

rifelpet
Copy link
Member

@rifelpet rifelpet commented Mar 24, 2020

The kubekins-e2e images were upgraded to bazel 2.2.0 so we need to upgrade to match. This should fix the bazel version errors we're seeing in presubmit jobs

Luckily this seems uninvasive so we'll be able to cherry-pick back as necessary.

once this is merged we can update the rules to their most recent versions too.

The kubekins-e2e images were upgraded to bazel 2.2.0 so we need to upgrade to match.

Luckily this seems uninvasive so we'll be able to cherry-pick back as necessary.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2020
@joshbranham
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2020
@k8s-ci-robot k8s-ci-robot merged commit 752087c into kubernetes:master Mar 24, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 24, 2020
@rifelpet
Copy link
Member Author

FYI the .bazelversion file wasnt added until after release-1.17 was cut, so we dont need to cherry-pick this back. Though the prow jobs of any PRs that target release branches will still use bazel 2.2.0. since there werent any other changes needed to support the new version, I dont think any action needs to be taken on the release branches.

@rifelpet rifelpet deleted the bazel-220 branch August 6, 2020 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants