Update default users for kubeconfig with supported distros #8798
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/retest |
| users = []string{"centos"} | ||
| case distros.DistributionAmazonLinux2, distros.DistributionRhel7, distros.DistributionRhel8: | ||
| users = []string{"ec2-user"} |
There was a problem hiding this comment.
Hm this logic is used on every cloud provider. AL2 makes sense to use ec2-user but RHEL7 and RHEL8 might have different users depending on the cloud provider. Maybe we add a conditional for aws here? though it would be good to cover other cloud providers as well.
There was a problem hiding this comment.
I think it has multiple choices, so should be ok. Maybe someone knows what to add for other cloud providers for centos.
There was a problem hiding this comment.
ah you're right. we can encourage users of other cloud providers to submit additions in separate PRs
|
/approve |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Kubernetes 1.19 stoped defaulting kubeconfig to http://localhost:8080 and needs a kubeconf in the home dir for kubectl to work by default.
kubernetes/kubernetes#86173