Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate support for Kubernetes 1.10 #8799

Merged
merged 1 commit into from
Mar 27, 2020

Conversation

johngmyers
Copy link
Member

Per our deprecation policy, I had deprecated Kubernetes 1.9 in Kops 1.18, scheduling for removal int Kops 1.19. This is the minimum necessary to avoid increasing the supported range.

This PR proposes to also deprecate Kubernetes 1.10, removing support in Kops 1.19. This narrows the supported range by one version.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 26, 2020
@hakman
Copy link
Member

hakman commented Mar 26, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2020
@rifelpet
Copy link
Member

This is meant to be in Kops 1.19 correct? If that's the case we'll need to wait until the release-1.18 branch is created before we merge this into master

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2020
@johngmyers
Copy link
Member Author

@rifelpet This is needed in kops 1.18 to announce and warn about the impending removal in kops 1.19.

@rifelpet
Copy link
Member

ah, that makes sense to me now. thanks

/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2020
@k8s-ci-robot k8s-ci-robot merged commit 7698323 into kubernetes:master Mar 27, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 27, 2020
@johngmyers johngmyers deleted the deprecate-1.10 branch March 27, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants