Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update metrics-server deployment apiVersion to apps/v1 #8842

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Update metrics-server deployment apiVersion to apps/v1 #8842

merged 1 commit into from
Apr 7, 2020

Conversation

elisiano
Copy link
Contributor

@elisiano elisiano commented Apr 3, 2020

Since kubernetes 1.16 does not support older deployments api versions
this needs to be updated as well.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 3, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @elisiano. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 3, 2020
@elisiano
Copy link
Contributor Author

elisiano commented Apr 3, 2020

I realize there are old installations in the wild, would it be better to have a separate manifest called v1.16.x.yaml instead?

@johngmyers
Copy link
Member

Yes, there should be a separate manifest.

@elisiano elisiano force-pushed the fix-metrics-server-deployment branch from 6a329e0 to f23cdec Compare April 4, 2020 07:59
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 4, 2020
@elisiano
Copy link
Contributor Author

elisiano commented Apr 4, 2020 •
edited
Loading

@johngmyers done, let me know if I should address anything else.

@johngmyers
Copy link
Member

I think you might need to add an addon.yaml to the directory, specifying the kubernetesVersion constraints.

@johngmyers
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 4, 2020
@elisiano
Copy link
Contributor Author

elisiano commented Apr 5, 2020

@johngmyers I've added the addon.yaml and fixed the README.md to reflect the cluster version constraints.

Please note that I'm not a user of addons, so I would need someone to verify that the file format is correct.

@elisiano
Added metrics-server deployment for 1.16+
b1bab7d 
Since kubernetes 1.16 does not support older deployments api versions
this needs to be updated as well.

Added addon.yaml and amended README.md
@elisiano elisiano force-pushed the fix-metrics-server-deployment branch from cd55a99 to b1bab7d Compare April 5, 2020 12:37
@justinsb
Copy link
Member

justinsb commented Apr 7, 2020

Thanks @elisiano - this looks great!

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elisiano, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2020
@johngmyers johngmyers mentioned this pull request Apr 7, 2020
Merged
@johngmyers
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 711816d into kubernetes:master Apr 7, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshbranham joshbranham Awaiting requested review from joshbranham

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@elisiano @k8s-ci-robot @johngmyers @justinsb