Update controller-tools and generate v1 CRDs #8875
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the k8s dependencies are updated to 1.17 we can update controller-tools to use apiextensions.k8s.io/v1 CRDs
https://github.com/kubernetes-sigs/controller-tools/releases
For the version of the CRD itself I went with v1alpha2 since to match the Kops API version that the CRDs are generated from.
It might be easier to view the diff with whitespace ignored