Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kubescheduler.config.k8s.io/v1alpha2 for Kubernetes 1.18+ #8883

Merged

Conversation

hakman
Copy link
Member

@hakman hakman commented Apr 9, 2020

kubescheduler.config.k8s.io/v1alpha1 was removed in 1.19 by kubernetes/kubernetes#89298.
kubescheduler.config.k8s.io/v1alpha2 was added in 1.18 by kubernetes/kubernetes#87628.

Fixes #8871

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 9, 2020
@hakman hakman force-pushed the kube-scheduler-config-v1alpha2 branch from fd7b332 to 5cf71cc Compare April 9, 2020 06:12
@olemarkus
Copy link
Member

kubescheduler.config.k8s.io/v1alpha1 was removed in 1.19 by kubernetes/kubernetes#89298.
kubescheduler.config.k8s.io/v1alpha1 was added in 1.18 by kubernetes/kubernetes#87628.

v1alpha1 and v1alpha2 respectively :) in case more people than me got confused here.

@olemarkus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2020
@hakman
Copy link
Member Author

hakman commented Apr 9, 2020

Thanks @olemarkus. Fixed the description :).

@rifelpet
Copy link
Member

rifelpet commented Apr 9, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2020
@hakman
Copy link
Member Author

hakman commented Apr 9, 2020

Thanks @rifelpet

@k8s-ci-robot k8s-ci-robot merged commit 5ecafd8 into kubernetes:master Apr 9, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Apr 9, 2020
@hakman hakman deleted the kube-scheduler-config-v1alpha2 branch April 9, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kops-latest periodic e2e is failing
4 participants