Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the spec docs #8902

Merged
merged 3 commits into from
Apr 15, 2020
Merged

Clean up the spec docs #8902

merged 3 commits into from
Apr 15, 2020

Conversation

olemarkus
Copy link
Member

  • try to make cluster and IG docs more consistent
  • split the IG docs between the spec and common operational use cases

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 11, 2020
rifelpet
rifelpet reviewed Apr 15, 2020
View reviewed changes
Copy link
Member

@rifelpet rifelpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor suggestions but looks good overall. thanks for cleaning this up! I like the separation of api field documentation vs kops command walkthroughs

docs/cluster_spec.md Outdated Show resolved Hide resolved
docs/instance_groups.md Outdated Show resolved Hide resolved
docs/instance_groups.md Show resolved Hide resolved
@olemarkus @rifelpet
Apply suggestions from code review
bb9b842 
Co-Authored-By: Peter Rifel <rifelpet@users.noreply.github.com>
@rifelpet
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit b42bd45 into kubernetes:master Apr 15, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Apr 15, 2020
@olemarkus olemarkus deleted the doc-fixes-2 branch April 15, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet left review comments

@joshbranham joshbranham Awaiting requested review from joshbranham

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@olemarkus @rifelpet @k8s-ci-robot