-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update security_groups.md #8912
Conversation
Welcome @zhming0! |
Hi @zhming0. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Co-Authored-By: Peter Rifel <rifelpet@users.noreply.github.com>
hmm i'm looking at the site preview and i don't think the markdown list is being formatted correctly. you might need to indent the |
try to make it render properly on Netlify's markdown engine
@rifelpet thanks for pointing it out. I didn't know we have this preview site feature, fancy 👍 . I tweaked it a little bit and it looks normal now. |
/retest |
look great, thanks! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet, zhming0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR updates
security_groups.md
in order to clear some confusions that developers might encounter when they see the name of "securityGroupOverride".Specifically,
Override
implies that the passed in security group will be the source of truth, but in reality the passed in security group will be modified.The awareness of this tiny detail will potentially prevent unwanted changes to some shared security groups.