Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update security_groups.md #8912

Merged
merged 3 commits into from
Apr 16, 2020
Merged

Update security_groups.md #8912

merged 3 commits into from
Apr 16, 2020

Conversation

zhming0
Copy link
Contributor

@zhming0 zhming0 commented Apr 14, 2020

This PR updates security_groups.md in order to clear some confusions that developers might encounter when they see the name of "securityGroupOverride".

Specifically, Override implies that the passed in security group will be the source of truth, but in reality the passed in security group will be modified.
The awareness of this tiny detail will potentially prevent unwanted changes to some shared security groups.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 14, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @zhming0!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @zhming0. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 14, 2020
@rifelpet
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 14, 2020
docs/security_groups.md Outdated Show resolved Hide resolved
Co-Authored-By: Peter Rifel <rifelpet@users.noreply.github.com>
@rifelpet
Copy link
Member

hmm i'm looking at the site preview and i don't think the markdown list is being formatted correctly. you might need to indent the This is due to... line to match the indentation of the line above it. I don't know for sure, the docs aren't super clear...

try to make it render properly on Netlify's markdown engine
@zhming0
Copy link
Contributor Author

zhming0 commented Apr 16, 2020

@rifelpet thanks for pointing it out. I didn't know we have this preview site feature, fancy 👍 .

I tweaked it a little bit and it looks normal now.

@zhming0
Copy link
Contributor Author

zhming0 commented Apr 16, 2020

/retest

@rifelpet
Copy link
Member

look great, thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet, zhming0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit ed2940d into kubernetes:master Apr 16, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants