Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the testing page #8934

Merged
merged 3 commits into from
Apr 18, 2020
Merged

Update the testing page #8934

merged 3 commits into from
Apr 18, 2020

Conversation

olemarkus
Copy link
Member

  • Use kubetest for running e2e
  • A section on unit/integration tests

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 18, 2020
Update the testing page
67b2895 
* Use kubetest for running e2e
* A section on unit/integration tests
hakman
hakman requested changes Apr 18, 2020
View reviewed changes
docs/development/testing.md Outdated Show resolved Hide resolved
@olemarkus @hakman
Update docs/development/testing.md
cfa1984 
Co-Authored-By: Ciprian Hacman <ciprianhacman@gmail.com>
rifelpet
rifelpet reviewed Apr 18, 2020
View reviewed changes
docs/development/testing.md Outdated Show resolved Hide resolved
docs/development/testing.md Outdated Show resolved Hide resolved
docs/development/testing.md Outdated Show resolved Hide resolved
docs/development/testing.md Outdated Show resolved Hide resolved
docs/development/testing.md Outdated Show resolved Hide resolved
@olemarkus @rifelpet
Apply suggestions from code review
8d6c393 
Co-Authored-By: Peter Rifel <rifelpet@users.noreply.github.com>
@rifelpet
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2020
@rifelpet
Copy link
Member

/retest

1 similar comment
@rifelpet
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit bae6a13 into kubernetes:master Apr 18, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Apr 18, 2020
@olemarkus olemarkus deleted the docs-e2e branch April 25, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet left review comments

@hakman hakman hakman requested changes

@joshbranham joshbranham Awaiting requested review from joshbranham

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@olemarkus @rifelpet @k8s-ci-robot @hakman