Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partially implement MountSensitive #8939

Merged
merged 1 commit into from
Apr 19, 2020
Merged

Partially implement MountSensitive #8939

merged 1 commit into from
Apr 19, 2020

Conversation

justinsb
Copy link
Member

We still don't actually support sensitive options, but it doesn't look
like we need them, MountSensitive is just called with empty
sensitiveOptions in a few places.

Issue #8908

@justinsb
Partially implement MountSensitive
145b71b 
We still don't actually support sensitive options, but it doesn't look
like we need them, MountSensitive is just called with empty
sensitiveOptions in a few places.

Issue kubernetes#8908
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 19, 2020
@justinsb justinsb mentioned this pull request Apr 19, 2020
Closed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2020
@hakman
Copy link
Member

hakman commented Apr 19, 2020

Thanks @justinsb.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2020
@k8s-ci-robot k8s-ci-robot merged commit 53f16fd into kubernetes:master Apr 19, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Apr 19, 2020
@hakman
Copy link
Member

hakman commented Apr 20, 2020

@justinsb This worked nicely for 1.11.
1.10 is still broken, this time because of the default image, based on Debian Jessie. Seems that packages already started disappearing. If 1.10 is going to work with the default image, I think it will need to be rebuilt based on Debian Stretch.

https://storage.googleapis.com/kubernetes-jenkins/logs/e2e-kops-aws-k8s-1-10/1252182276532342790/artifacts/15.206.178.213/kops-configuration.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshbranham joshbranham Awaiting requested review from joshbranham

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justinsb @k8s-ci-robot @hakman