-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for containerd v1.3.4 #8941
Conversation
@@ -53,8 +53,8 @@ func (b *ContainerdOptionsBuilder) BuildOptions(o interface{}) error { | |||
|
|||
// Set containerd based on Kubernetes version | |||
if fi.StringValue(containerd.Version) == "" { | |||
if b.IsKubernetesGTE("1.17") { | |||
containerd.Version = fi.String("1.3.3") | |||
if b.IsKubernetesGTE("1.18") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this version changing? i'd expect to see another else if
condition instead of updating this one condition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We set this to 1.17 a few months ago to be able to test while 1.18 was unstable. The expected release version is 1.18.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah ok, and that PR was also only in kops 1.18. 👍
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @rifelpet :) |
https://github.com/containerd/containerd/releases/tag/v1.3.4