Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profiling and protect kernel defaults flags #8967

Merged
merged 6 commits into from
Apr 27, 2020
Merged

Profiling and protect kernel defaults flags #8967

merged 6 commits into from
Apr 27, 2020

Conversation

michalschott
Copy link
Contributor

@michalschott michalschott commented Apr 23, 2020 •
edited
Loading

Adding support for two flags required by CIS / aquasecurity/kube-bench.

Work on this started previously here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 23, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @michalschott. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/api area/documentation labels Apr 23, 2020
@michalschott
Copy link
Contributor Author

/assign @hakman

@michalschott
Copy link
Contributor Author

/assign @rifelpet

@rifelpet
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 24, 2020
@michalschott michalschott force-pushed the profiling_and_protect_kernel_defaults_flags branch from 6341f46 to 8a17c72 Compare April 24, 2020 08:40
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Apr 24, 2020
hakman
hakman requested changes Apr 24, 2020
View reviewed changes
docs/cluster_spec.md Outdated Show resolved Hide resolved
docs/cluster_spec.md Outdated Show resolved Hide resolved
docs/cluster_spec.md Outdated Show resolved Hide resolved
pkg/apis/kops/componentconfig.go Outdated Show resolved Hide resolved
pkg/apis/kops/componentconfig.go Outdated Show resolved Hide resolved
pkg/apis/kops/componentconfig.go Outdated Show resolved Hide resolved
pkg/apis/kops/v1alpha2/componentconfig.go Outdated Show resolved Hide resolved
pkg/apis/kops/v1alpha2/componentconfig.go Outdated Show resolved Hide resolved
pkg/apis/kops/v1alpha2/componentconfig.go Outdated Show resolved Hide resolved
pkg/apis/kops/v1alpha2/componentconfig.go Outdated Show resolved Hide resolved
@michalschott @hakman
Update docs/cluster_spec.md
367f885 
Co-Authored-By: Ciprian Hacman <ciprianhacman@gmail.com>
@michalschott michalschott force-pushed the profiling_and_protect_kernel_defaults_flags branch from 676e27b to 367f885 Compare April 25, 2020 12:33
@hakman
Copy link
Member

hakman commented Apr 25, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2020
michalschott added a commit to michalschott/kops that referenced this pull request Apr 25, 2020
@michalschott
Copying changes from #kubernetes#8967.
5868724
@michalschott michalschott mentioned this pull request Apr 25, 2020
Merged
@rifelpet
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michalschott, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2020
@k8s-ci-robot k8s-ci-robot merged commit f6068dd into kubernetes:master Apr 27, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Apr 27, 2020
k8s-ci-robot added a commit that referenced this pull request Apr 27, 2020
@k8s-ci-robot
Merge pull request #8979 from michalschott/cherry-pick-of-#8967-upstr…
8a218a2 
…eam-release-1.17

cherry pick of #8967 upstream release 1.17
@michalschott michalschott deleted the profiling_and_protect_kernel_defaults_flags branch April 28, 2020 08:31
@olemarkus olemarkus mentioned this pull request May 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus olemarkus left review comments

@hakman hakman hakman requested changes

@joshbranham joshbranham Awaiting requested review from joshbranham

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@rifelpet rifelpet

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/documentation area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@michalschott @k8s-ci-robot @rifelpet @hakman @olemarkus